Add support for director/federation contact info as a configuration #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
added
enhancement
|
@haoming29 Can this have multiple values? If we only want one contact we should not use the object field here and instead have string fields. |
Good point. Yeah I think at the end of the day it's simply two string config params (just happen to have the shared parent node). I'll redo the params and I'll let you know when it's ready. |
|
@CannonLock Just redid the config and we should be good with string values. |
|
Removing myself as reviewer as this will not include ui changes. |
jhiemstrawisc
requested changes
Apr 4, 2024
jhiemstrawisc
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #983
@CannonLock this PR introduced a new object type parameter called
Director.SupportContact. You may need to patch in additional UI form for this. Thanks!