Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin external c++ dependencies at a specific commit #1022

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Apr 1, 2024

Closes #881

This PR pins commit when building from source in dev/production containers for s3 plugin, xrdcl plugin, and lotman

@haoming29 haoming29 requested a review from jhiemstrawisc April 1, 2024 19:52
@haoming29 haoming29 added this to the v7.7.0 milestone Apr 1, 2024
@haoming29 haoming29 added infrastructure GitHub Actions, Release management, and CI container labels Apr 1, 2024
@haoming29 haoming29 force-pushed the build-fixed-xrd-http branch from a17845a to f1683f2 Compare April 1, 2024 19:56
@haoming29 haoming29 changed the title Ping external c++ dependencies at a specific commit Pin external c++ dependencies at a specific commit Apr 1, 2024
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhiemstrawisc jhiemstrawisc merged commit ad8eac2 into PelicanPlatform:main Apr 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container infrastructure GitHub Actions, Release management, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should avoid building xrootd-s3-http from main
2 participants