Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Testing Code #1036

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Remove Testing Code #1036

merged 2 commits into from
Apr 3, 2024

Conversation

CannonLock
Copy link
Contributor

Added a 'cache' string here so that I could view the cache only Lotman configuration.

This is to remove that leaked testing code.

@CannonLock CannonLock requested a review from haoming29 April 3, 2024 14:25
haoming29
haoming29 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haoming29
Copy link
Contributor

The parameter validation test failed due to no key exists for Cache.Concurrency which is an int type, not sure why this would cause error?

@CannonLock
Copy link
Contributor Author

@haoming29 Looks like the Cache.Concurrency component list got dropped somewhere? I just tacked it on here as these are both minor changes.

@haoming29
Copy link
Contributor

@haoming29 Looks like the Cache.Concurrency component list got dropped somewhere? I just tacked it on here as these are both minor changes.

Thanks for the patch!

@haoming29 haoming29 merged commit d9c0491 into PelicanPlatform:main Apr 3, 2024
11 checks passed
@haoming29 haoming29 mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CannonLock @haoming29