Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config fixups #1057

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Config fixups #1057

merged 3 commits into from
Apr 5, 2024

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock commented Apr 5, 2024 •
edited
Loading

Moved over the multilines to literal formatting rather then folding as Markdown expects literal.

https://yaml-multiline.info/

haoming29
haoming29 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter error was fixed. Thanks for tidying this up! It would be useful for the record if you can briefly explain in the PR why we switch from >- to |+

@CannonLock
Copy link
Contributor Author

@haoming29 Good call, check new description.

@CannonLock CannonLock merged commit ffbf548 into PelicanPlatform:main Apr 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CannonLock @haoming29