Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes #106

Merged
merged 3 commits into from
Sep 7, 2023
Merged

UI changes #106

merged 3 commits into from
Sep 7, 2023

Conversation

CannonLock
Copy link
Contributor

  • Adds a redirect for non auth'd users
  • Refines the UI in the first 10 minutes where data is not yet populated

Screenshot 2023-09-06 at 8 34 59 AM (2)

- Make the no data feedback ui look better
@CannonLock
Copy link
Contributor Author

@bbockelm It would be sweet if the prometheus metrics got moved behind auth if they are going to be private. If those metric endpoints are meant to be public why not let a user see the homepage without auth?

@CannonLock CannonLock requested a review from bbockelm September 6, 2023 14:48
@bbockelm
Copy link
Collaborator

bbockelm commented Sep 6, 2023

Yes - the Prometheus metrics are going to be behind the authorization long term. It's one of the tickets for @turetske in v7.1.0.

- Auto update graphs each minute
- Update the text to mark last update time
Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Merging.

@bbockelm bbockelm merged commit b39030e into main Sep 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants