Move default S3 url style from defaults.yaml to config.go #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we have no way to tell whether defaults in defaults.yaml are user-provided
or not, the default there of `Origin.S3UrlStyle` was throwing an error meant to
notify users that they have incompatible config variables set.
This moves setting of that default into config.go where we now use `viper.SetDefault`,
which later on allows us to `viper.IsSet("Origin.S3UrlStyle")` without catching our
own default.
jhiemstrawisc
added
bug
haoming29
suggested changes
Apr 8, 2024
|
Sorry for the typo, should be good to go now. |
haoming29
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we have no way to tell whether defaults in defaults.yaml are user-provided or not, the default there of
Origin.S3UrlStylewas throwing an error meant to notify users that they have incompatible config variables set.This moves setting of that default into config.go where we now use
viper.SetDefault, which later on allows us toviper.IsSet("Origin.S3UrlStyle")without catching our own default.