Fix broken URLs of namespaces from the topology at the director #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
added
bug
haoming29
changed the title
haoming29
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URLs for the topology namespace in director are broken. The current code gives
http:8000asurlorauthUrlfor namespaces from the topology (try/api/v1.0/director_ui/severs). The original code 10fd09f was correct in thaturl.Parserequires the scheme to be present, which is contrary to what I tested in the playground: #1043 (comment)But since
url.Parsedocumented that parsing a url without scheme is invalid, let's keep doing what we were doing to ensure nothing breaks.