Only push the production container when the release was cut #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhlin
reviewed
Apr 8, 2024
Good call. I pass a variable from the |
brianhlin
reviewed
Apr 9, 2024
| @@ -192,7 +194,7 @@ jobs: | |||
| with: | |||
| context: . | |||
| file: ./images/Dockerfile | |||
| push: ${{ github.repository == 'PelicanPlatform/pelican' && github.event_name != 'pull_request' }} | |||
| push: ${{ github.repository == 'PelicanPlatform/pelican' && (inputs.release_workflow || false) }} | |||
There was a problem hiding this comment.
What's with the || false here? Kinda seems superfluous?
There was a problem hiding this comment.
it does look superfluous but otherwise the yaml check will fail when the workflow was not triggered by the workflow call (in which case release_workflow is undefined) and gives the error:
Error: Input does not meet YAML 1.2 "Core Schema" specification: push
Support boolean input list: `true | True | TRUE | false | False | FALSE`
brianhlin
approved these changes
Apr 9, 2024
haoming29
force-pushed
the
only-push-when-release
branch
from
8fbbeff to
b1d2e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the critical bug described in #1075 but leave the part untouched where "automatically tagging the latest release with the largest semantic version as the latest"