Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made additional retryable errors #1101

Merged

Conversation

joereuss12
Copy link
Contributor

Made StoppedTransferError and Cannot allocate memory a retryable error

Made StoppedTransferError and Cannot allocate memory a retryable error.
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic idea is good, just nits about the visibility. Since we want others to eventually use the client module, we need to be extremely careful about exported types and methods.

client/errorAccum.go Outdated Show resolved Hide resolved
client/handle_http.go Outdated Show resolved Hide resolved
@joereuss12 joereuss12 requested a review from bbockelm April 12, 2024 16:49
@bbockelm bbockelm merged commit eb07f39 into PelicanPlatform:main Apr 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cannot allocate memory a retryable error Make stopped transfer a retryable error
3 participants