Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite redirect of UI init page #1193

Merged
merged 2 commits into from
May 1, 2024

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Apr 30, 2024

As recently found out in the Denver cache deployment and NSDF S3 origin deployment, the web UI is trapped in an infinite redirect at the server start (not yet initialized with admin password). This PR is to fix this issue.

To test the fix, follow the instructions below:

  • Remove your admin password file (backup first): rm /etc/pelican/server-web-passwd
  • Build and run an origin ./pelican origin serve
  • Go to the admin website at https://localhost:8444/
  • You should be redirect to the initialization code page at /view/initialization/code/

@haoming29 haoming29 added bug Something isn't working critical High priority for next release cache Issue relating to the cache component origin Issue relating to the origin component labels Apr 30, 2024
@haoming29 haoming29 added this to the v7.8.0 milestone Apr 30, 2024
@haoming29 haoming29 requested a review from CannonLock April 30, 2024 20:35
@haoming29 haoming29 mentioned this pull request May 1, 2024
@haoming29 haoming29 linked an issue May 1, 2024 that may be closed by this pull request
Copy link
Contributor

@CannonLock CannonLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @haoming29 Note that this won't close #1184 as I also make the mistake of expecting the error response to take the form { error: "" } which is a mistake.

@haoming29 haoming29 removed a link to an issue May 1, 2024
@haoming29
Copy link
Contributor Author

LGTM! @haoming29 Note that this won't close #1184 as I also make the mistake of expecting the error response to take the form { error: "" } which is a mistake.

Sounds good. I'll remove the link to close #1184

@haoming29 haoming29 merged commit 004b244 into PelicanPlatform:main May 1, 2024
17 of 19 checks passed
@haoming29 haoming29 deleted the fix-origin-ui-redir branch May 1, 2024 19:17
haoming29 added a commit that referenced this pull request May 1, 2024
* Fix infinite redirect of UI init page

* Improve test coverage on the fixed bug
haoming29 added a commit that referenced this pull request May 1, 2024
* Fix infinite redirect of UI init page

* Improve test coverage on the fixed bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cache Issue relating to the cache component critical High priority for next release origin Issue relating to the origin component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants