Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile updates #128

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

CannonLock
Copy link
Contributor

  • Specify website input so only rebuilds on update
  • Remove alternative docker build commands
    • The assumption is you are running in the appropriate env

- Specify website input so only rebuilds on update
- Remove alternative docker build commands
  - The assumption is you are running in the appropriate env
@jhiemstrawisc
Copy link
Member

I'm certainly not a makefile guru. Outside of testing that I can still run make with the various arguments, are there other things I should look at testing or reviewing?

Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested each of the targets, and they all appeared to run and complete as expected.

@jhiemstrawisc jhiemstrawisc merged commit 38a0175 into PelicanPlatform:main Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants