Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issuer for self-monitoring and scitokens issuer name #1284

Merged
merged 4 commits into from
May 15, 2024
Merged

Fix issuer for self-monitoring and scitokens issuer name #1284

merged 4 commits into from
May 15, 2024

Conversation

haoming29
Copy link
Contributor

Fixes #1275

@haoming29 haoming29 added bug Something isn't working origin Issue relating to the origin component labels May 14, 2024
@haoming29 haoming29 added this to the v7.9.0 milestone May 14, 2024
@haoming29 haoming29 requested a review from turetske May 14, 2024 21:56
turetske
turetske requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a test to show that the issuers are generated correctly in xrootd/authorization_test.go?

@haoming29
Copy link
Contributor Author

Can you create a test to show that the issuers are generated correctly in xrootd/authorization_test.go?

There's existing test coverage and I updated the test file to reflect the change: xrootd/resources/test-scitokens-monitoring.cfg

@turetske
Copy link
Collaborator

Can you create a test to show that the issuers are generated correctly in xrootd/authorization_test.go?

There's existing test coverage and I updated the test file to reflect the change: xrootd/resources/test-scitokens-monitoring.cfg

Ah, okay. I missed that somehow.

turetske
turetske approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran it locally just to be sure.

@turetske turetske merged commit 8729905 into PelicanPlatform:main May 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turetske turetske turetske approved these changes

Assignees
No one assigned
Labels
bug Something isn't working origin Issue relating to the origin component
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.

Pelican origin/cache uses external issuer for self-tests
2 participants
@haoming29 @turetske