Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed object copy directory checking for multiple sources #1337

Merged

Conversation

turetske
Copy link
Collaborator

@turetske turetske commented May 27, 2024

Object copy had incomplete error checking for whether the destination was a directory when copying multiple sources

@turetske turetske requested a review from joereuss12 May 27, 2024 17:53
@turetske turetske linked an issue May 27, 2024 that may be closed by this pull request
7 tasks
Copy link
Contributor

@joereuss12 joereuss12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joereuss12 joereuss12 merged commit c526478 into PelicanPlatform:main May 28, 2024
19 checks passed
@joereuss12
Copy link
Contributor

Actually after further investigation, it looks like 'object get' has the same issue. I can make a PR for that quick though

@turetske turetske deleted the object-copy-directory-check branch February 5, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic error for text that is not a recognized flag
2 participants