Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit against entire repo #139

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

jhiemstrawisc
Copy link
Member

Now that we have pre-commit, we should be able to cut down on noise generated by some of the github actions. This commit runs pre-commit against the entire repo to whip everything into shape.

Now that we have pre-commit, we should be able to cut down on noise generated
by some of the github actions. This commit runs pre-commit against the entire
repo to whip everything into shape.
@jhiemstrawisc
Copy link
Member Author

@CannonLock I requested a review from you because I noticed that pre-commit modified a few svg's. in origin_ui/src/public. I'm guessing it was just dealing with some whitespace/new lines, but can you double check that it didn't do anything wonky?

Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reviewed the SVG file changes and it appears that the only change is a newline. Appears to be valid still.

@bbockelm bbockelm added the internal Internal code improvements, not user-facing label Sep 16, 2023
@bbockelm bbockelm added this to the v7.1.0 milestone Sep 16, 2023
@bbockelm bbockelm merged commit 28cab32 into PelicanPlatform:main Sep 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal code improvements, not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants