Add Namespace Management CLI Commands #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds several new commands to the CLI for managing namespaces. The commands added include: - Register a new namespace - Delete a namespace - List all namespaces - Get a specific namespace This commit also adds the necessary flag definitions and configurations for each command. In addition, the commit includes the implementation of JWT-based authentication when registering a namespace. This includes handling of JSON Web Key Sets (JWKS), signing/verification of payloads, nonce generation, and HTTP request/response handling. The code also includes functions for loading and saving signatures to/from a file, and for loading ECDSA public/private keys from PEM and JWKS formats.
- Checked error returns from 'viper.BindPFlag' calls for robust error handling. - Commented out unused functions 'writeSignatureToFile', 'loadSignatureFromFile', 'verifySignature' to prevent 'unused' linting errors. - Utilized the err variable after client.Do(req) call to prevent ineffectual assignment.
…ust error handling.
bbockelm
requested changes
Jul 25, 2023
There was a problem hiding this comment.
A few cleanup items requested; comments are inline.
The big picture item is to switch to using the JWT library that's already used in the client. See:
https://github.com/PelicanPlatform/pelican/blob/main/origin_ui/origin.go#L148-L165
That should actually decrease the size of the PR quite a bit.
2. clean code 3. avoid panic'ing within the CLI
…erver_creds.go now also takes a curve argument as input
bbockelm
reviewed
Aug 1, 2023
bbockelm
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
A few review comments - but given we're short on time I'll merge anyway:
- Better to unmarshal into
structs instead ofmap[string]interface{}; that will ensure the expected keys are present. - Elsewhere in the code, we've been using CamelCase instead of underscores.
- I suspect there's a better way to handle the JWKS serialization besides converting it to a map. A follow-up might be to dig through the
jwklibrary to see if there's some serialization routines we can reuse from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds several new commands to the CLI for managing namespaces. The commands added include:
In addition, the commit includes the implementation of JWT-based authentication when registering a namespace. This includes handling of JSON Web Key Sets (JWKS), signing/verification of payloads, nonce generation, and HTTP request/response handling.
The code also includes functions for loading and saving signatures to/from a file, and for loading ECDSA public/private keys from PEM and JWKS formats.