Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commenting code that causes errors when using a fork #145

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Remove commenting code that causes errors when using a fork #145

merged 1 commit into from
Sep 20, 2023

Conversation

turetske
Copy link
Collaborator

Removing the commenting code, at least until we decide on a fix so it's no longer causing a block.

@turetske turetske requested a review from CannonLock September 19, 2023 20:54
@turetske turetske self-assigned this Sep 19, 2023
jhiemstrawisc
jhiemstrawisc approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This block just removes the comment, so we can still see coverage metrics by looking into the logs. Let's follow up on how to get this to work later.

@jhiemstrawisc jhiemstrawisc merged commit ae47221 into PelicanPlatform:main Sep 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

@CannonLock CannonLock Awaiting requested review from CannonLock

Assignees

@turetske turetske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turetske @jhiemstrawisc