Test Origin Login APIs #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a unit test for the origin login api's. This effectively tests: 1. Code-based login when no password is set 2. Password reset API 3. Password-based login API 4. "whoami" API The tests have been ran on both windows and in a linux container and shows everything running successfully.
Closed
|
Changing the reviewer over to Emma. |
turetske
requested changes
Sep 28, 2023
I added 2 new tests per Emma's request. In addition I also discovered fatal errors with the test itself. I noticed I forgot to add a `m.Run()` line to my TestMain() so the tests were not actually running. Once adding this the tests were failing because I was setting up the handles multiple times. So instead of configuring origin ui every time I just reconfigure the AuthDB whenever I add a user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a unit test for the origin login api's. The tests have been ran on both windows and in a linux container and shows everything running successfully. This effectively tests: