-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The cache now gets x509ClientAuthenticationPrefixes from the director… #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turetske
force-pushed
the
ssl-defer-cache
branch
from
October 11, 2024 15:40
de42b64
to
d31313a
Compare
jhiemstrawisc
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor requests for changes/explanations but I've verified that both test cases work as expected for me locally.
… and uses them in its config -- Creates a DirectorAPI endpoint which returns the list of x509ClientAuthenticationPrefixes -- The Cache retrieves this list from the director while getting NSAds from the Director -- The xrootd cache config now sets "http.tlsclientauth defer" -- for each entry in the x509ClientAuthenticationPrefixes, the xrootd cache config sets "http.tlsrequiredprefeix <prefix>" -- Adding tests
turetske
force-pushed
the
ssl-defer-cache
branch
from
October 18, 2024 14:56
d31313a
to
d0a9117
Compare
-- Test cleanup and clarity
turetske
force-pushed
the
ssl-defer-cache
branch
from
October 18, 2024 16:24
7a00d58
to
79277ca
Compare
jhiemstrawisc
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and uses them in its config
The behavior is that if a prefix is in
http.tlsrequiredprefix <prefix>
then when an access occurs with proper x509 certs, then it can pass even if it doesn't have a proper token. This will also remove the issue where when accessing an object via a browser, it will ask for an x509 certificate even when it's not needed.For the testing, there are few things you want to do.
No longer asking for a certificate for browser accesses:
Testing that the defer check works:
i.
openssl x509 -in <configdir>/certifications/tls.crt -noout -hash
ii. add
u <user>.0 <prefix> lr
to<configdir>/xrootd/authfile
curl -v -k -L https://<directorurl>/<prefix>/<object> --tlsv1.3 --cert <configdir>/certificates/tls.crt --key <configdir>/certificates/tls.key
and see that it successfully accesses the file