Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Prometheus Retention #1670

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Configurable Prometheus Retention #1670

merged 8 commits into from
Oct 25, 2024

Conversation

patrickbrophy
Copy link
Collaborator

This PR addresses issue #1640. This PR adds a new configuration called Retention. This PR defines the default retention time as 15 days.

@patrickbrophy patrickbrophy added enhancement New feature or request cache Issue relating to the cache component origin Issue relating to the origin component director Issue relating to the director component registry Issue relating to the registry component labels Oct 21, 2024
@patrickbrophy patrickbrophy linked an issue Oct 21, 2024 that may be closed by this pull request
Add Prom Retention Configuration #1640
Closed
CannonLock
CannonLock requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@CannonLock CannonLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't commit on the soundness except for how it relates to the UI, but this tweak makes sure the duration UI is used in the config rather then the default string UI.

docs/parameters.yaml Outdated Show resolved Hide resolved
CannonLock
CannonLock approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@CannonLock CannonLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax LGTM

jhiemstrawisc
jhiemstrawisc requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to request a user-facing config name, otherwise looks straight forward and correct

docs/parameters.yaml Outdated Show resolved Hide resolved
jhiemstrawisc
jhiemstrawisc approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhiemstrawisc jhiemstrawisc merged commit b0bbed2 into PelicanPlatform:main Oct 25, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

@CannonLock CannonLock CannonLock approved these changes

Assignees
No one assigned
Labels
cache Issue relating to the cache component director Issue relating to the director component enhancement New feature or request origin Issue relating to the origin component registry Issue relating to the registry component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Prom Retention Configuration
3 participants
@patrickbrophy @CannonLock @jhiemstrawisc