Additional user interfaces and APIs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
force-pushed
the
ui_apis
branch
2 times, most recently
from
69bc0c9 to
9e67d24
Compare
This replaces the stub API at /api/v1.0/health with a real component health API. Components can self-register their status with the metrics sub-module and have this status be reflected in the API response.
When stdout is a terminal, have the code-based registration be more readable.
`whoami` simply returns whether the user is authenticated and, if so, the current username. `loginInitialized` returns whether the login service has been initialized (if not, then the code auth needs to be performed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out a few user interfaces / APIs that should be useful for Cannon to build the initial login page:
/api/v1.0/origin-ui/loginInitialized) returns whether or not the admin password has been set for the origin./api/v1.0/origin-ui/whoami) returns the current login status and username (if applicable)/api/v1.0/health) now reflects the status of the various components.This builds on top of #16; that should be merged first.