Put prometheus metrics behind federation/origin token #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
requested changes
Oct 5, 2023
-- Added a checkPromToken function in prometheus.go to check the tokens
-- Added unit tests for checking the metrics
-- Fixed missing "Bearer " in redirect_test
-- Tokens are now in WLCG format
-- Added scope check
-- Added comment clarifying issuer claim retrieval
-- Parse federation jwks correctly (as json)
-- Changed ES512 to ES256
turetske
force-pushed
the
turetske/prometheus
branch
from
73b0b66 to
209e3a0
Compare
|
@jhiemstrawisc Addressed the code review comments, if you could review it again. |
jhiemstrawisc
requested review from
jhiemstrawisc
and removed request for
jhiemstrawisc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue Issue #6 and puts the accessing of prometheus metrics behind the federation or origin token.