Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Object Delete Command #1816

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Implement Object Delete Command #1816

wants to merge 10 commits into from
+472 −31

Conversation

Saartank
Copy link
Collaborator

@Saartank Saartank commented Dec 9, 2024

This PR closes #1685 by implementing an object delete command.

The object delete command is not openly supported and is marked hidden. It deletes data from the origin and does not clean data from caches the data might have propagated to.

The object delete command supports the recursive option to delete collections.

jhiemstrawisc
jhiemstrawisc requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, feel free to disagree with me on any change request. If we come to different conclusions, the discussion will be useful for us to make sure we're doing things right.

client/director.go Outdated Show resolved Hide resolved
client/director_test.go Show resolved Hide resolved
client/fed_linux_test.go Outdated Show resolved Hide resolved
client/fed_linux_test.go Show resolved Hide resolved
client/fed_linux_test.go Show resolved Hide resolved
client/main.go Show resolved Hide resolved
client/main.go Outdated Show resolved Hide resolved
client/main.go Outdated Show resolved Hide resolved
director/director.go Outdated Show resolved Hide resolved
cmd/object_delete.go Show resolved Hide resolved
@Saartank Saartank marked this pull request as draft December 13, 2024 14:25
@Saartank Saartank added enhancement New feature or request client Issue affecting the OSDF client director Issue relating to the director component labels Dec 13, 2024
@Saartank Saartank modified the milestones: v7.13.0, v7.12.0 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
client Issue affecting the OSDF client director Issue relating to the director component enhancement New feature or request
Projects
None yet
Milestone
v7.12.0
Development

Successfully merging this pull request may close these issues.

object delete
2 participants
@Saartank @jhiemstrawisc