Docker images: Put binaries into standard locations #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pelican and osdf go into /usr/local/bin - pelican-server and osdf-server go into /usr/local/sbin Fixes PelicanPlatform#1744
jhiemstrawisc
approved these changes
Dec 11, 2024
|
@matyasselmeci / @jhiemstrawisc -- are there any backward compatability items to note here? |
|
I don't think there should be. We start containers by passing them a list of arguments, not by invoking any binary name directly. This preserves the formatting, but stores the binary in a separate location, so I'd be surprised if it didn't translate directly to our deployments. I'll double check that our (minimal) existing documentation doesn't need to be updated to reference the new path. |
|
The previous binary paths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1744