Overhaul config names #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbockelm I think this is ready for review, even though tests aren't passing yet. It looks like the failed tests are fetching and testing against the head of the repo's main branch. Any idea what's going on there? |
|
@jhiemstrawisc - I think the git merge algorithm was creating some of the issues you were seeing... just because it merges cleanly doesn't mean it's actually creating working code! I did a quick rebase, touched up some items, and I think it's now back on track. |
bbockelm
requested changes
Oct 5, 2023
jhiemstrawisc
force-pushed
the
issue-130
branch
from
1d5efff to
7bc2a0a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
In issue PelicanPlatform#130 we discussed making config variables hierarchical, such that each variable describes which service it affects. One goal was to keep the hierarchies flat (<= 2 layers). This PR breaks out the config variables and assigns them to various parent services. It also adds many new viper config variables to `docs/parameters.yaml` so that users can figure out which components of Pelican they have control over.
Without this, if there are changes between the base and new code, the params module may be in an inconsistent state.
bbockelm
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #130 we discussed making config variables hierarchical, such that each variable describes which service it affects. One goal was to keep the hierarchies flat (<= 2 layers). This PR breaks out the config variables and assigns them to various parent services. It also adds many new viper config variables to
docs/parameters.yamlso that users can figure out which components of Pelican they have control over.