Add configuration for Prometheus to limit cardinality #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
requested changes
Jan 15, 2025
web_ui/prometheus.go
Outdated
| @@ -396,6 +403,13 @@ func ConfigureEmbeddedPrometheus(ctx context.Context, engine *gin.Engine) error | |||
| }}, | |||
| }, | |||
| } | |||
|
|
|||
| // Cardinality limits for Prometheus, configured via Pelican configuration file | |||
| scrapeConfig.LabelLimit = uint(param.Monitoring_LabelLimit.GetInt()) | |||
There was a problem hiding this comment.
I haven't spent much time with this code in general. Why does it become necessary to set these scrape limits in three different places?
There was a problem hiding this comment.
I had a hard time wrapping my head around it as well, but I figured if we set it to often it too often it wouldn't be an issue.
jhiemstrawisc
requested changes
Jan 20, 2025
jhiemstrawisc
requested changes
Jan 22, 2025
jhiemstrawisc
approved these changes
Jan 22, 2025
patrickbrophy
requested review from
jhiemstrawisc
and removed request for
jhiemstrawisc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1311. This PR uses the default values as described in this design doc. This PR adds the ability to configure the label name and value length limits, the number of labels per time series, and the scrape limit. More information about these parameters can be found here