Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new graph components #189

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Create new graph components #189

merged 4 commits into from
Oct 9, 2023

Conversation

CannonLock
Copy link
Contributor

  • Create setting drawer
  • Create input to manipulate Prometheus rate graph - Provide sensible defaults

@CannonLock
Create new graph components
32026b7 
- Create setting drawer
- Create input to manipulate Prometheus rate graph
    - Provide sensible defaults
@bbockelm bbockelm requested a review from haoming29 October 9, 2023 14:17
haoming29
haoming29 previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Graph data didn't update for new incoming data
  • Another issue that wasn't related to this PR but needs attention is that the epoch time sent from backend is 3~ min ahead of the current time. We might want to open a new issue to fix this.

@haoming29 haoming29 dismissed their stale review October 9, 2023 19:54

Changes done.

@haoming29 haoming29 self-requested a review October 9, 2023 19:55
haoming29
haoming29 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes addressed the data update frozen issue. Approved.

origin_ui/src/components/graphs/RateGraph.tsx
</FormControl>
</Grid>
<Grid item xs={1} m={"auto"}>
<IconButton href={"https://prometheus.io/docs/prometheus/latest/querying/examples/#subquery"} size={"small"}><QuestionMark/></IconButton>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to open external links in a new tab

@haoming29 haoming29 merged commit 6f8c8ab into PelicanPlatform:main Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CannonLock @haoming29