Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template rendering failure #191

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

bbockelm
Copy link
Collaborator

@bbockelm bbockelm commented Oct 6, 2023

Additionally, add a simple regression test to ensure that the template at least compiles.

@bbockelm bbockelm requested a review from turetske October 6, 2023 13:23
@bbockelm bbockelm added this to the v7.1.0 milestone Oct 6, 2023
@bbockelm bbockelm added the bug Something isn't working label Oct 6, 2023
Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the test if possible and I'll do another review. It's weird that it passes linux but fails on others.

Additionally, add a simple regression test to ensure that the template
at least compiles.
Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turetske turetske merged commit ef21162 into PelicanPlatform:main Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants