Add Status Box Component #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is due to the fact that I built this off of the graph addition then separated it after. Once that gets merged things will work. |
haoming29
approved these changes
Oct 9, 2023
| <Grid item xs={12} lg={4}> | ||
| <StatusBox/> | ||
| </Grid> | ||
| <Grid item xs={12} lg={8}> | ||
| <Box sx={{backgroundColor: "#F6F6F6", borderRadius: "1rem"}} p={2}> |
There was a problem hiding this comment.
- It can be very helpful if we can display the error messages for the the critical and warning status.
- We might want to have different colors for the different status (critical/warning)
- The color fill is a bit heavy for the user reading the dashboard for OK and warning status. A colored-border box might be more user friendly?
- Capitalize the first letter of the status?
Added back deleted import. Sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.