Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check of cookie login for prometheus #193

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Added check of cookie login for prometheus #193

merged 5 commits into from
Oct 9, 2023

Conversation

turetske
Copy link
Collaborator

@turetske turetske commented Oct 9, 2023 

-- Refactored origin and federation check into their own module to be used by other functions
-- Added a README explaining which tokens is it okay to sign with the Federation and which aren't
-- Added a check for the authorization via the login cookie

@turetske
Added check of cookie login for prometheus
ec9b03c 
    -- Refactored origin and federation check into their own module to be used by other functions
    -- Added a README explaining which tokens is it okay to sign with the Federation and which aren't
@turetske
Fixed parameter names
3095547 
Fixed origin_serve_test not making "/run" directory
@CannonLock
Copy link
Contributor

LGTM

CannonLock
CannonLock approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@CannonLock CannonLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in that it provides the promised function.

jhiemstrawisc
jhiemstrawisc requested changes Oct 9, 2023
View reviewed changes
web_ui/authorization.go Show resolved Hide resolved
web_ui/prometheus_test.go Outdated Show resolved Hide resolved
@jhiemstrawisc jhiemstrawisc merged commit f4776f7 into PelicanPlatform:main Oct 9, 2023
6 checks passed
@turetske turetske deleted the prometheus_cookie branch November 7, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

@CannonLock CannonLock CannonLock approved these changes

@bbockelm bbockelm Awaiting requested review from bbockelm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turetske @CannonLock @jhiemstrawisc