Testing common transport timeouts #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a unit test that tests functionality of common transport timeouts now that they can be configured. Did not include all timeouts since the test demonstrates functionality enough and it became too difficult to focus too much on.
jhiemstrawisc
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
While the regression tests don't test every option that's configurable via the setupTransport function, the nature of that function is such that if one option breaks, they probably all break. For that reason, I think it's fine that we test a few of the options until we can come back and cover more of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a unit test that tests functionality of common transport timeouts now that they can be configured. Did not include all timeouts since the test demonstrates functionality enough and it became too difficult to focus too much on.