Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent TLSSkipVerify from being overwritten #234

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

haoming29
Copy link
Contributor

This fix should close #229 by preventing TLSSkipVerify param from being overwritten by the CA cert param.

@haoming29 haoming29 requested a review from bbockelm October 13, 2023 17:46
@haoming29 haoming29 changed the title Prevent TLSSkipVerify to be overwritten Prevent TLSSkipVerify from being overwritten Oct 13, 2023
@bbockelm bbockelm added the bug Something isn't working label Oct 14, 2023
@bbockelm bbockelm added this to the v7.2.0 milestone Oct 14, 2023
@haoming29 haoming29 merged commit 857006e into PelicanPlatform:main Oct 14, 2023
@haoming29 haoming29 deleted the fix-tls branch October 14, 2023 15:51
bbockelm pushed a commit that referenced this pull request Oct 16, 2023
Prevent TLSSkipVerify from being overwritten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS skip verify config is overwritten when a CA cert is present
2 participants