Make default log level part of pelican config #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
reviewed
Oct 13, 2023
joereuss12
force-pushed
the
make-log-level-part-of-config-branch
branch
from
a66c0cf to
8b3a0a8
Compare
bbockelm
requested changes
Oct 17, 2023
joereuss12
force-pushed
the
make-log-level-part-of-config-branch
branch
from
805c0fe to
e827278
Compare
|
Okay, should be fixed with rebasing now and the commits look better. Still running into the issue I found yesterday about root.go not being able to read in defaults.yaml so working towards a fix now. |
bbockelm
requested changes
Oct 17, 2023
Closed
This commit should have fixed all the rebasing issues. Work towards pelican log level able to be set in config. The -d flag takes priority of all log level settings. Also, found some variable names that were still in snake case and changed them to camelcase. This PR did work not too long ago but is now running into issues. It seems that in root.go it cannot read defaults.yaml so the log level cannot be set in there. Working towards a fix.
Now that the configurations are cleaned up, can successfully add the log level as part of config. This should work for all methods (pelican, osdf, and stashcp). However, for stashcp, nothing happens for log levels set in config and you must use the `-d` flag since it does not go through root.
joereuss12
force-pushed
the
make-log-level-part-of-config-branch
branch
from
e827278 to
25150b0
Compare
bbockelm
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default log level to
ErrorLevelwithindefaults.yaml. The user is now able to modify their config file and override the default to whatever log level they would like. In addition, the -d flag functionality should remain the same and override whatever config is set. Also found a problem inobject_copy.gowhich this does not work if the binary is named stashcp, should work now. Fixed some noticed snake case variable names floating around too and decided to fix them.