Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Director auth headers and add regression test #274

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jhiemstrawisc
Copy link
Member

Since the bug isn't super easy to catch in the diff, it was coming from:

cacheNS := NamespaceAd{}
cacheNS.Path = ns.Path
cacheNS.RequireToken = ns.UseTokenOnRead
cacheAdMap[cacheAd] = append(cacheAdMap[cacheAd], cacheNS)

I'm not sure why I ever did this because the appended value (cacheNS) should have just been nsAd like it is for the similar origin logic. I'll probably figure it out around the same time I figure out how many licks it takes to get to the center of a tootsie pop.

Once we're comfortable merging this, I'll patch it into 7.1 as this constitutes a bugfix.

Fixes issue #258

Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhiemstrawisc jhiemstrawisc merged commit 81c53cd into PelicanPlatform:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants