Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev container build failure by specify base image platform #286

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix dev container build failure by specify base image platform #286

merged 1 commit into from
Oct 25, 2023

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Oct 25, 2023 •
edited
Loading

Hot fix for the latest build-dev-container GHA failure on main branch as scitokens-oauth2-server base image isn't built for arm platform. Fix by specifying --platform on base image as amd64.

@haoming29 haoming29 added the bug Something isn't working label Oct 25, 2023
@haoming29 haoming29 added this to the v7.2.0 milestone Oct 25, 2023
jhiemstrawisc
jhiemstrawisc approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhiemstrawisc jhiemstrawisc merged commit 71f20c7 into PelicanPlatform:main Oct 25, 2023
6 checks passed
@haoming29 haoming29 deleted the fix-fail-build-on-arm branch October 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@haoming29 @jhiemstrawisc