Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related pieces in this PR:
First, the contents in the new
/images
are what I've cooked up for building a container that enters in theentrypoint.sh
script. The idea is that a kubernetes deployment can launch the pod with an argument like "director_serve" and this will cause the entrypoint script to launch thepelican_director_serve
daemon through supervisord on the specified port. I haven't added supervisord configurations for the namespace registry or the origin because I thought those would be best added by the people most familiar with them.Second, the new build+push action will trigger whenever there's a push to main or a tag that matches v[0-9]+.[0-9]+.[0-9]+. This will cause goreleaser to run and generate its release artifacts. In particular, the release binary artifact for linux/amd64 will be used later to build the container (at some point it would be good to think about other architectures, but let's walk before we run). The action should then push the container to harbor with a tag that's either "latest" in the event that the action was triggered by a regular push, or a tag matching the commit's tag if the commit has a tag. I thought this might be a nice way to handle keeping tagged stable versions and development versions of the container organized in harbor.