Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace client cleanup #30

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Namespace client cleanup #30

merged 2 commits into from
Aug 10, 2023

Conversation

bbockelm
Copy link
Collaborator

@bbockelm bbockelm commented Aug 1, 2023

This implements small changes to the namespace client to simplify the registration process, including:

  • Use federation auto-discovery to find the namespace API endpoint.
  • Use the default config file location of the private key.
  • Generate the public key in-memory instead of requiring it at the CLI.

Example commands that now work:

$ pelican -f osg-htc.org namespace register --prefix /test_bbockelm

and

$ osdf namespace list

bbockelm added 2 commits August 1, 2023 08:47
@bbockelm
Leverage auto-discovery for namespace registration
95995d6 
- Use federation auto-discovery to make specifying the location of
  the namespace URL optional.
- Use the IssuerJWK by default as the private key location.
@bbockelm
Fixup OSDF federation discovery.
2e16182
@bbockelm bbockelm requested a review from CohenQU August 1, 2023 13:55
jhiemstrawisc
jhiemstrawisc approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge so that I can continue building on changes.

@jhiemstrawisc jhiemstrawisc merged commit 5f91ee1 into PelicanPlatform:main Aug 10, 2023
@bbockelm bbockelm mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

@CohenQU CohenQU Awaiting requested review from CohenQU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbockelm @jhiemstrawisc