Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade status component #316

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Upgrade status component #316

merged 1 commit into from
Nov 2, 2023

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock commented Nov 2, 2023 •
edited
Loading

@CannonLock
Upgrade status component
91fa938 
- Remove some padding
- More robust to errors parsing response
- Status components are no longer hardcoded
@CannonLock CannonLock requested a review from haoming29 November 2, 2023 00:12
haoming29
haoming29 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Manually and visually confirmed that when /heath api returns error, status box will catch it and render an error box while the rest of the page can render as is. Also confirmed that a new component key won't break the rendering.

origin_ui/src/components/StatusBox.tsx
break
case "federation":
component = "Federation"
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add another case when #175 is merged.

@haoming29 haoming29 merged commit eb91cfd into PelicanPlatform:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Origin UI crashes when /health API returns with a missing component
2 participants
@CannonLock @haoming29