Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bypassed authentication for /config API #321

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix bypassed authentication for /config API #321

merged 1 commit into from
Nov 3, 2023

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Nov 3, 2023 •
edited
Loading

This fixes the issue with /api/v1.0/config not checking User field in ctx and allows unauthed user to access config.

@haoming29
Fix auth for /config api
6ecf1df 
Add header comment to explain how authHandler works
@haoming29 haoming29 marked this pull request as ready for review November 3, 2023 16:51
@haoming29 haoming29 requested a review from CannonLock November 3, 2023 16:52
@haoming29 haoming29 added the bug Something isn't working label Nov 3, 2023
@haoming29 haoming29 added this to the v7.2.0 milestone Nov 3, 2023
@haoming29 haoming29 self-assigned this Nov 3, 2023
CannonLock
CannonLock approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@CannonLock CannonLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works good!

@haoming29 haoming29 merged commit cb67d77 into PelicanPlatform:main Nov 3, 2023
6 checks passed
@haoming29 haoming29 deleted the fix-config-auth branch November 7, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CannonLock CannonLock CannonLock approved these changes

Assignees

@haoming29 haoming29

Labels
bug Something isn't working
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@haoming29 @CannonLock