Use Server.Hostname than os.Hostname() in generating CA #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #303
With this PR merged, we should be consistently using Server.Hostname from parameters at all places. This PR also changes the param type of hostname from url to string, and noted the default value will be
os.Hostname()Note to the reviewer. I've tested that by changing the
Server.Hostnamefrom its default tolocalhost, remove existing CA file, spinning up an origin to let it generate new CA, and copy the CA file to/etc/pelican/certificates/tlsca.crt, and re-run the origin, the self-test works as expected.