Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no auth token is present, do not emit verbose error message #404

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

bbockelm
Copy link
Collaborator

If someone does a curl against the metrics endpoint with neither token nor cookie, there's a long error message that's emited. We should only have debugging information when there's a reasonable chance that someone was trying to authenticate.

@haoming29 - can you take a look at this? It was irritating me as the current director does not even try to authenticate yet queries my /metric endpoint at the rate of about 2Hz, causing 1-2 dozen log lines per second when I'm trying to debug.

If someone does a `curl` against the metrics endpoint with neither
token nor cookie, there's a long error message that's emited.  We
should only have debugging information when there's a reasonable
chance that someone was trying to authenticate.
@haoming29
Copy link
Contributor

If someone does a curl against the metrics endpoint with neither token nor cookie, there's a long error message that's emited. We should only have debugging information when there's a reasonable chance that someone was trying to authenticate.

@haoming29 - can you take a look at this? It was irritating me as the current director does not even try to authenticate yet queries my /metric endpoint at the rate of about 2Hz, causing 1-2 dozen log lines per second when I'm trying to debug.

I agree that we should not produce verbose log message when there's no token present, but I can't reproduce your issue where the director didn't try to authenticate against /metrics url. Which director are you referring to? Is that a local/dev version or some director on our test instance? Which /metrics endpoint is the director accessing? The internal one or the one for an origin? and what's your steps to reproduce?

Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might worth a separate issue for the director's unauthed behavior

@haoming29 haoming29 merged commit 614063b into PelicanPlatform:main Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants