Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation Overview #221 #411

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Federation Overview #221 #411

merged 1 commit into from
Nov 30, 2023

Conversation

CannonLock
Copy link
Contributor

  • Implements Federation overview which provides a series of links to all Federation components
  • Quiet Failure

Closes #221

@CannonLock
Federation Overview PelicanPlatform#221
eaacfd3 
- Implements Federation overview which provides a series of links to all Federation components
- Quiet Failure

Closes PelicanPlatform#221
haoming29
haoming29 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The URLs can't work if I ran origin in a container (the hostnames are invalid) but I assume in production it should work as expected.

@CannonLock
Copy link
Contributor Author

@haoming29 What do you mean they do not work? I have then set to ingest the config values, did you run into a case where they did not do that correctly?

@haoming29
Copy link
Contributor

@haoming29 What do you mean they do not work? I have then set to ingest the config values, did you run into a case where they did not do that correctly?

The values are correct, just that for my container the hostnames are alphanumeric value like fae8c2865de4 and when I click that link it will lead to nowhere but I assume this shouldn't be an issue if we ran it in a VM or server.

@CannonLock CannonLock merged commit bf26456 into PelicanPlatform:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Federation Overview
2 participants
@CannonLock @haoming29