Implement recursive uploads #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbockelm Would you like me to look more into somehow keeping the directory structure on the server side? As of now, it only spits all of the files into the specified directory on the origin because I could not figure out how to do a client side PUT with directories. |
joereuss12
force-pushed
the
recursive-uploads-branch
branch
from
21cd896 to
64e4794
Compare
|
Marking this ready for review. Cannot create a unit test because it requires a director to be spinning so it can find the |
|
@joereuss12 - there are some conflicts to fix up here. |
turetske
approved these changes
Dec 5, 2023
First draft of recursive uploads. This will go through a directory and upload every file to the destination. The only problem is that it will not maintain the same directory structure since I could not find a way to have PUT work with directories.
With the use of gowebdav.Mkdir() the UploadDirectory function now maintains directory structure on the server side.
Also fixes issues with progress bars for recursive uploads. It is at the same state as recursive downloads so it looks fine without debug logging but is wonky with it. Functionality should work fine.
joereuss12
force-pushed
the
recursive-uploads-branch
branch
from
64e4794 to
bf4ba6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of recursive uploads. This will go through a directory and upload every file to the destination. The only problem is that it will not maintain the same directory structure since I could not find a way to have PUT work with directories.