-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean UI #43
Conversation
e1db13e
to
8eb31c3
Compare
@CannonLock - I think you might want to back out the last commit. It introduces a wholesale reformat of the code base (maybe something your editor did?) and removes a bunch of entries from I've got a separate branch locally for doing the wholesale reformat. Let's keep this one just to the initial UI. |
- Add Password Page - Hook up to the backend
- Update Main Dockerfile for website build - Create Makefile - Update CI accordingly - Update supervisord script accordingly
@CannonLock - did a rebase to clean up the PR. However, the build itself is failing on my local environment:
This is an EL7 host -- I suspect the node and npm versions are now considered ancient and are the culprits for the failure. Do you know what a minimum working version would be? |
Actually, scratch that. I just did a blind update from EPEL and now have a new enough version to work -- no need to debug old cruft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get the framework for the UI merged in so approving right now.
However, it seems that the gin routes aren't configured correctly -- it's not actually serving up the pages as expected (e.g., even just the index page at /
is blank in my testing). It could be my fault - maybe something got lost by the rebase?
Here's what I'm doing for the test:
osdf -d -f osg-htc.org origin serve -v /tmp/test:/test
Regardless, I'm approving for now so the fixes for the display issue are a small patch to review.
Add a more reasonable default target; simply typing `make` will result in the `pelican-build` target being run. Remove the placeholder as it doesn't actually seem necessary at this point.
Add in the code and password creation section of the pelican ui