Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean UI #43

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Clean UI #43

merged 6 commits into from
Aug 30, 2023

Conversation

CannonLock
Copy link
Contributor

Add in the code and password creation section of the pelican ui

@CannonLock CannonLock marked this pull request as ready for review August 23, 2023 14:42
@CannonLock CannonLock force-pushed the clean-ui branch 4 times, most recently from e1db13e to 8eb31c3 Compare August 23, 2023 16:25
@bbockelm
Copy link
Collaborator

@CannonLock - I think you might want to back out the last commit. It introduces a wholesale reformat of the code base (maybe something your editor did?) and removes a bunch of entries from go.sum. The latter is breaking the build.

I've got a separate branch locally for doing the wholesale reformat. Let's keep this one just to the initial UI.

CannonLock and others added 5 commits August 30, 2023 08:17
- Add Password Page
- Hook up to the backend
- Update Main Dockerfile for website build
- Create Makefile
- Update CI accordingly
- Update supervisord script accordingly
@bbockelm
Copy link
Collaborator

@CannonLock - did a rebase to clean up the PR. However, the build itself is failing on my local environment:

npm ERR! Linux 3.10.0-1160.15.2.el7.x86_64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v6.17.1
npm ERR! npm  v3.10.10
npm ERR! path /home/cse496/bbockelm/projects/pelican/origin_ui/src/node_modules/.staging/@types/scheduler-8470f33f/package.json
npm ERR! code ENOTDIR
npm ERR! errno -20
npm ERR! syscall open

npm ERR! ENOTDIR: not a directory, open '/home/cse496/bbockelm/projects/pelican/origin_ui/src/node_modules/.staging/@types/scheduler-8470f33f/package.json'
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /home/cse496/bbockelm/projects/pelican/origin_ui/src/npm-debug.log

This is an EL7 host -- I suspect the node and npm versions are now considered ancient and are the culprits for the failure. Do you know what a minimum working version would be?

@bbockelm
Copy link
Collaborator

Actually, scratch that. I just did a blind update from EPEL and now have a new enough version to work -- no need to debug old cruft.

Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get the framework for the UI merged in so approving right now.

However, it seems that the gin routes aren't configured correctly -- it's not actually serving up the pages as expected (e.g., even just the index page at / is blank in my testing). It could be my fault - maybe something got lost by the rebase?

Here's what I'm doing for the test:

osdf -d -f osg-htc.org origin serve -v /tmp/test:/test

Regardless, I'm approving for now so the fixes for the display issue are a small patch to review.

Add a more reasonable default target; simply typing `make` will
result in the `pelican-build` target being run.

Remove the placeholder as it doesn't actually seem necessary at this point.
@bbockelm bbockelm merged commit 255ddff into main Aug 30, 2023
@bbockelm bbockelm deleted the clean-ui branch August 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants