Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NextJS to ^14 #454

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock requested a review from haoming29 December 5, 2023 14:58
@CannonLock
Copy link
Contributor Author

@haoming29 I am a reviewer on another PR from the CI that I approve but since it is dependencies I have to update then rebuild to get it right. So this is the same PR as linked above and that I have approved just merged in.

@haoming29
Copy link
Contributor

Looks like upgrading from 13 to 14 for Next.js won't bring too many compatibility issues itself but just want to double check, is there any packages we are using that have compatibility issue with 14?

@CannonLock
Copy link
Contributor Author

CannonLock commented Dec 5, 2023

@haoming29 NPM handles all that. When I change next to v14 and run npm i all the v14 next dependencies are updated to the correct versions as well. You can see these updates in the package-lock.json.

@haoming29
Copy link
Contributor

@haoming29 NPM handles all that. When I change next to v14 and run npm i all the v14 next dependencies are updated to the correct versions as well. You can see these updates in the package-lock.json.

Great! Then this should be good to go.

@haoming29 haoming29 merged commit 46bd3ab into PelicanPlatform:main Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants