-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable key chaining to protect super/sub namespaces #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
force-pushed
the
issue-333
branch
from
December 5, 2023 23:36
27d2945
to
ea6d415
Compare
Closes issue #333 |
Notes on testing:
|
turetske
requested changes
Dec 6, 2023
Let's say that `/foo/bar` is already registered with some set of associated public keys. It makes sense that we wouldn't want someone else to register `/foo` or `/foo/bar/baz` unless they had the permission of the owner of `/foo/bar`, because we treat namespaces hierarchically. This token chaining feature allows a registry to be run such that it will deny requests to register `/foo` or `/foo/bar/baz` unless the registration token passed during registration is signed by a key that's already associated with `/foo/bar`.
jhiemstrawisc
force-pushed
the
issue-333
branch
from
December 6, 2023 21:50
4bf217a
to
1bea9cb
Compare
turetske
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another tool for admins, this PR allows a registry to be run such that it requires key chaining to register a sub/super namespace of an already-registered namespace. For example, if
/foo/bar
is registered, when key chaining is enabled, neither/foo
nor/foo/bar/baz
can be registered unless by a key paired with/foo/bar
. Another example -- if/foo
and/foo/bar
are both registered, then we cannot register/foo/bar/baz
unless the key is also registered to one of the superspace set (/foo
and/foo/bar
.I think eventually we should enable these types of registrations via tokens as well -- if I own
/foo
and I want to enable Emma to register/foo/bar
, I should be able to generate a token with the key registered to/foo
to enable any public key Emma wants to use. Based on feedback to this PR, I'll open that as an issue for future development.