Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build containers but don't push on PR #467

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

CannonLock
Copy link
Contributor

No description provided.

@CannonLock
Copy link
Contributor Author

Closes #287

@CannonLock CannonLock force-pushed the pre-build-containers branch from 9ac7949 to f6a3831 Compare December 6, 2023 20:40
@CannonLock
Copy link
Contributor Author

@jhiemstrawisc If anything I think the test failure is proof that this does what it is supposed to ;)

@haoming29 haoming29 added this to the v7.3.0 milestone Dec 7, 2023
@haoming29
Copy link
Contributor

haoming29 commented Dec 7, 2023

@jhiemstrawisc If anything I think the test failure is proof that this does what it is supposed to ;)

@CannonLock Could you try to merge against the latest main? The error in release GH is fixed by #469 which has been merged in

@CannonLock CannonLock requested a review from haoming29 December 7, 2023 17:08
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this change

@haoming29 haoming29 merged commit 2fa3b68 into PelicanPlatform:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The test suite that runs on a PR doesn't check that containers are buildable
2 participants