Fix progress bars w/ recursive uploads and downloads #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
approved these changes
Dec 8, 2023
|
@joereuss12 and @jhiemstrawisc Just so you know, Cannon's PR to fix the npm build issue is merged in and we should be good to go |
The progress bars now appear below the debug log as they are running, also disabled progress bars with specified debug log output. Figured you don't need the bars to be printed to a specific log file.
joereuss12
force-pushed
the
fix-mpb-recursive-upload-and-download-branch
branch
from
f6f0663 to
f4c9407
Compare
|
Sounds good, pushed again after rebase, hopefully no more issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress bars now appear below the debug log as they are running and are not duplicated. Also, disabled progress bars with specified debug log output. Figured you don't need the bars to be printed to a specific log file.