Improve the use of the X-Pelican-* responses #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we never released a production version of the director using the `X-Osdf-*` headers, take the time to switch the internals to 'Pelican' instead. This additionally fixes a potential panic when the `X-Osdf-Namespace` header is missing from the director response.
The `X-Pelican-Namespace` header is needed to let the remote client know whether or not to use a token. It should always be set, even if there's not enough information available on how it should *generate* a credential.
Previously, the panic was logged at the Error level; this wasn't useful as the string gets printed out twice to stderr (as the panic is converted to an error and re-raised). With this, clients that have debugging enabled will have far more useful information on panics for the dev team.
|
Merging this without review -- right now, focusing on getting most of the PRs in to allow a reformat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
X-Pelican-*instead ofX-Osdf-*.X-Pelican-Namespace, even when the credential generation isn't known.X-Pelican-Namespaceheader is missing.