Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go fmt as one of the linters #49

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

bbockelm
Copy link
Collaborator

Go has a reference source code formatting - and the VS code defaults seem to like auto-formatting to it. We might as well enable it in the linters just to keep things consistent.

Note this disables reporting all linter issues as there's a codebase-wide reformat that should be done as a separate branch once some other pending work lands.

@bbockelm
Copy link
Collaborator Author

@jhiemstrawisc - did some investigation into linters last night and found out that go fmt is simply an optional linter we can enable in the existing check.

I'd like to run a cross-codebase go fmt -s -w ./... once #39 is merged (hopefully today?). When that's done, we can revert the second change here which causes the linter to only flag new problems during PRs.

Go has a reference source code formatting - and the VS code defaults
seem to like auto-formatting to it.  We might as well enable it in
the linters just to keep things consistent.
@bbockelm
Copy link
Collaborator Author

Merging just to lock this approach in place.

@bbockelm bbockelm merged commit 0890cbb into PelicanPlatform:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant