Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pelican object get and pelican object put #490

Merged
merged 5 commits into from
Jan 10, 2024
Merged

pelican object get and pelican object put #490

merged 5 commits into from
Jan 10, 2024

Conversation

joereuss12
Copy link
Contributor

The command pelican object get and pelican object put separated out from pelican object copy.

@joereuss12 joereuss12 linked an issue Dec 12, 2023 that may be closed by this pull request
Object get/put #259
Closed
@joereuss12
Copy link
Contributor Author

So far just a draft PR with basic functionality for Pelican object get. Working towards object put as well as unit tests for both of these functionalities.

@joereuss12 joereuss12 changed the title pelican object get pelican object get and pelican object put Dec 12, 2023
@joereuss12 joereuss12 marked this pull request as ready for review January 2, 2024 22:27
@joereuss12
Copy link
Contributor Author

Still actually working on getting the tests done for this but making "not a draft" in case we just want to approve. Going to try and get them done before release (progress already made for them just need to fix #504 / #507)

See #582 for test issue

@joereuss12
Copy link
Contributor Author

Still actually working on getting the tests done for this but making "not a draft" in case we just want to approve.

Turns out we should just approve, this should be ready for review.

jhiemstrawisc
jhiemstrawisc requested changes Jan 8, 2024
View reviewed changes
client/main.go Outdated Show resolved Hide resolved
client/main.go Outdated Show resolved Hide resolved
client/main.go Outdated Show resolved Hide resolved
client/main.go Show resolved Hide resolved
client/main.go Outdated Show resolved Hide resolved
client/main.go Show resolved Hide resolved
cmd/object_get.go Show resolved Hide resolved
cmd/object_put.go Show resolved Hide resolved
cmd/object_put.go Outdated Show resolved Hide resolved
cmd/object_put.go Outdated Show resolved Hide resolved
@jhiemstrawisc jhiemstrawisc added this to the v7.4.0 milestone Jan 10, 2024
@joereuss12
First draft of pelican object get
b853fcf 
Commit for the first draft of `pelican object get`, barely tested but
functionality seems correct for now. Took a lot from `pelican object
copy` and kept its workflow very similar
@joereuss12
First draft of pelican object put
94e237d 
First draft and not tested that much but basic functionality is there
@joereuss12
Fixes to object get/put
c2abdac 
Addresses Justin's suggestions for object get/put, cleaning things up
and allowing PUTs to work with the director
@joereuss12 joereuss12 force-pushed the object-get-and-put-branch branch from adeac97 to c2abdac Compare January 10, 2024 18:20
@jhiemstrawisc jhiemstrawisc merged commit 4c09b62 into PelicanPlatform:main Jan 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.

Object get/put
2 participants
@joereuss12 @jhiemstrawisc